docs: add endpoint for opting out phone numbers in SNS v2#434
Open
quetzalliwrites wants to merge 2 commits intomainfrom
Open
docs: add endpoint for opting out phone numbers in SNS v2#434quetzalliwrites wants to merge 2 commits intomainfrom
quetzalliwrites wants to merge 2 commits intomainfrom
Conversation
quetzalliwrites
requested review from
HarshCasper,
baermat and
bentsku
as code owners
quetzalliwrites
added
documentation
Deploying localstack-docs with
|
| Latest commit: |
ebe2e72
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44472d2c.localstack-docs.pages.dev |
| Branch Preview URL: | https://docs-sns-phone-opt-out.localstack-docs.pages.dev |
quetzalliwrites
force-pushed
the
docs-sns-phone-opt-out
branch
from
2b91eae to
ebe2e72
Compare
remotesynth
approved these changes
Feb 13, 2026
Collaborator
Author
baermat
requested changes
Feb 17, 2026
Member
baermat
left a comment
baermat
left a comment
There was a problem hiding this comment.
Looks mostly goot to me! I have a couple of suggestions which would be nice to get in, and then we are set 🎉
| :::note | ||
| * This endpoint is intended for **local testing only**. | ||
| * The opt-out list is stored per account. | ||
| * Adding the same phone number multiple times is safe. Internally, phone numbers are stored in a set, so duplicate entries are ignored. |
Member
There was a problem hiding this comment.
I would suggest the following
Suggested change
| * Adding the same phone number multiple times is safe. Internally, phone numbers are stored in a set, so duplicate entries are ignored. | |
| * Adding the same phone number multiple times is idempotent. |
The set part provides a bit too much internal information in my opinion, which might also change at some point
|
|
||
|
|
||
| ### Phone opt-outs | ||
|
|
Member
There was a problem hiding this comment.
nit: I would move this to the end of the endpoints section, because it is the least likely one to be used. We really only have this for completeness' sake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
DOC-48